www: use node:lts in build-site.sh
#2639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nodejs.org website build uses `fibers` which is broken on Node.js 16 due to an incompatibility with the version of V8 that it contains. Switch the Docker image used to build the website from `node:latest` to `node:lts` to buy some time for the website to migrate off `fibers`.
This was referenced Apr 29, 2021
rvagg
approved these changes
Apr 30, 2021
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
🤦 I don't even want to know why fibers is getting involved here but using lts is a good move regardless
Member
Author
FWIW I recommended (nodejs/nodejs.org#3828 (comment)) that the website drops use of fibers. |
AshCripps
approved these changes
Apr 30, 2021
richardlau
changed the title
docker:lts in build-site.shnode:lts in build-site.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nodejs.org website build uses
fiberswhich is broken on Node.js 16due to an incompatibility with the version of V8 that it contains.
Switch the Docker image used to build the website from
node:latesttonode:ltsto buy some time for the website to migrate offfibers.This is live -- I edited the script on the www server, tested it and then synced the changes into this PR via:
Fixes: #2123 (comment)