Skip to content

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Sep 4, 2024

Refs: #3806
Refs: rvagg/rpi-newer-crosstools#3


Ansible:

  • release-mnx-ubuntu2404_docker-x64-1
  • test-digitalocean-ubuntu2204_docker-x64-1
  • test-digitalocean-ubuntu2204_docker-x64-2
  • test-ibm-ubuntu2204_docker-x64-1

@richardlau
Copy link
Member Author

richardlau commented Sep 4, 2024

@richardlau richardlau marked this pull request as ready for review September 4, 2024 19:17
@richardlau
Copy link
Member Author

Test build: https://ci.nodejs.org/job/richardlau-node-test-commit-arm-fanned/14/

Passed 🎉. I'll need to update the two DigitalOcean hosts, but this is ready for review now.

@richardlau
Copy link
Member Author

I'll need to update the two DigitalOcean hosts

Done.

@richardlau
Copy link
Member Author

Note, when landing, node-cross-compile must be updated to add building on the cross-compiler-rhel9-armv7-gcc-12-glibc-2.28 label, to match the updated VersionSelectorScript.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look. Mostly rubberstamp

@richardlau richardlau merged commit d3f52e3 into nodejs:main Sep 6, 2024
@richardlau
Copy link
Member Author

@richardlau
Copy link
Member Author

Test build:

Looks okay -- compilation happened in the new container with the updated compiler and most tests passed (with the exception of parallel/test-debugger-heap-profiler timing out, which appears to have already been happening before this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants