packer: add multiarch rust support to orka images#4316
Merged
sxa merged 1 commit intonodejs:mainfrom May 1, 2026
Merged
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
targos
approved these changes
Apr 30, 2026
UlisesGascon
approved these changes
Apr 30, 2026
Member
Author
|
Deployed and tested and this is now ready for the v26 release, therefore I am merging. Thank you @ryanaslett for your work on this today! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to allow nodejs/node#63015 to work as it requires the ability to target x64 for producing the dual binaries in the
macos15-release-pkgaxis of theiojs+releasejob.This has been tested using an additional patch on top of that PR which ran the same command within the build on the dynamic orka node (so isn't permanent and is removed when the machine is deprovisioned).
I don't think there's value in running this to force the installation of the arm64 target too (so x64 could do both) but if anyone disagrees and thinks that should be added we can update it.
@ryanaslett It would be good if we can jump on a call today related to this if you're available. I presume that even though the existing rust stuff is only in the
testtemplate it still takes effect on the release machines (on the basis that the release ones definitely do have rust!)