doc: document process for access to jenkins jobs #554

mhdawson · 2016-11-25T20:47:29Z

Document process for allowing members outside
of the build working group the access required to be able
to edit or run jobs associated with their working group.

Document process for allowing members outside of the build working group the access required to be able to edit or run jobs associated with their working group.

mhdawson · 2016-11-25T20:48:36Z

@nodejs/build please take a look.
Supports: #526

mhdawson · 2016-12-06T22:03:11Z

@jbergstroem, @gibfahn @joaocgreis updated based on comments so far. Let me know what you think.

mhdawson · 2016-12-07T22:13:38Z

@gibfahn @jbergstroem second set of comments addressed.

mhdawson · 2016-12-09T14:37:34Z

Addressed next set comments.

mhdawson · 2016-12-09T15:32:30Z

Addressed new comments.

mhdawson · 2016-12-12T22:27:21Z

@jbergstroem can you review now that @gibfahn is happy with it.

gibfahn · 2016-12-13T17:12:50Z

@mhdawson After nodejs/security-wg#9 (comment), maybe we should s/workgroup/working group everywhere...

mhdawson · 2016-12-13T21:45:19Z

Ok addressed most of the remaining comments. @jbergstroem in respect to formatting to W80 is there an easy way to do that ? I've tried to stick under the 72 chars but evening out by hand would be a bit of work and I don't think it matters since when its viewed in markdown, markdown will handle making it look good.

jbergstroem · 2016-12-14T01:05:58Z

@mhdawson: 72 or 80 doesn't really matter. For me, the point of markdown is that its very readable rendered (github) and in your editor (vim, et al). A consistent line length is just generally easier to consume. Anyway, since we're down to bikeshedding I'm +1 regardless.

gibfahn · 2017-01-03T11:26:39Z

@nodejs/build would be really good to get this landed so people in teams can get access to jobs.

@mhdawson With two reviews I think if there are no objections this should be good to land, people can always PR improvements.

phillipj · 2017-01-03T11:35:49Z

Other than a microscopic nit, this LGTM

mhdawson · 2017-01-03T21:32:44Z

Since there are 2 LGTMs now I'll plan to land tomorrow.

Document process for allowing members outside of the build working group the access required to be able to edit or run jobs associated with their working group. PR-URL: #554 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Phillip Johnsen <johphi@gmail.com>

gibfahn · 2017-01-04T17:06:06Z

Landed in 1fcbba2

doc: document process for access to jenkins jobs

a360b00

Document process for allowing members outside of the build working group the access required to be able to edit or run jobs associated with their working group.