doc: fix the PR template CONTRIBUTING.md link #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
I'd say it doesn't need to wait for #314 , there's already a link to CONTRIBUTING.md in the PULL_REQUEST template, this just fixes the link. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
@gibfahn think this is good to land |
Using ./CONTRIBUTING.md in the PR template resolves to https://github.com/nodejs/citgm/compare/CONTRIBUTING.md. Use the full path instead (as is done in Node.js core). Note that the CONTRIBUTING.md file hasn't yet been added (the PR to add it is nodejs#314).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ./CONTRIBUTING.md in the PR template resolves to
https://github.com/nodejs/citgm/compare/CONTRIBUTING.md. Use the full path
instead (as is done in Node.js core).
Note that the CONTRIBUTING.md file hasn't yet been added (the PR to add it is
#314).
Link to core PR template: https://raw.githubusercontent.com/nodejs/node/master/.github/PULL_REQUEST_TEMPLATE.md
Checklist