Replacearch with apk --print-arch in Dockerfile-alpine.template
#1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc #1026 |
SimenB
approved these changes
Oct 29, 2019
SimenB
reviewed
Oct 29, 2019
functions.sh
Outdated
| function get_arch() { | ||
| local arch | ||
| case $(uname -m) in | ||
| case $(apk --print-arch) in |
Member
There was a problem hiding this comment.
this only works for alpine, yes?
Contributor
|
I meant in the |
PeterDaveHello
force-pushed
the
update-functions.sh
branch
from
7098174 to
cc22ef6
Compare
PeterDaveHello
force-pushed
the
update-functions.sh
branch
from
cc22ef6 to
cb7bada
Compare
PeterDaveHello
changed the title
apk --print-arch instead of uname -m in functions.sharch with apk --print-arch in Dockerfile-alpine.template
Member
Author
|
I misunderstood, should be fixed now. |
Member
|
Should all the alpine images be updated, or just wait for the next versions? |
Member
Author
|
I think it's for the next version, no need to change it immediately. @tianon what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @tianon in docker-library/official-images#6871