Enable travis-ci test builds. Closes #13 #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chorrell
changed the title
Contributor
|
LGTM 👍 |
Contributor
|
LGTM as well. I'll take a pass at merging my prior work for smoke testing builds. It builds off of the official project's npm smoke tests. |
Contributor
Author
|
@retrohacker Cool. It should be easy enough to modify the .travis.yml file to have that run the smoke testing builds |
Contributor
|
Just submitted #140 which adds some trivial smoke testing, much simpler in scope than what @retrohacker planned. Let me know what you think. |
Contributor
|
Just submitted #141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables Travis-CI for a simple test build of the docker-node images. This will streamline image updates a bit as the build test we use (via ./testbuild.sh) will happen automatically for pull requests etc.
We'll need Travis-CI enabled for this GitHub repo as well.
I'll do a follow-up PR to the README.md so it shows the build status :)