-
Notifications
You must be signed in to change notification settings - Fork 2k
Moved the GPG keys to an environment variable #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is there a benefit of moving the GPG keys to an environment variable that I do not see? This will introduce another environment variable to the global scope which is passed along when extending or running the image. Also, |
|
Good call. I did this because it seems like a trend for images (especially alpine variants, to build the environment with one chained command. Moving the keys to a variables makes it easier to do this (at least, makes the code clearer) |
d10da7b to
883a678
Compare
|
Done! |
|
The respective Dockerfiles should be updated with |
|
Ooops, forgot about that |
883a678 to
d7e3107
Compare
|
Done! |
|
This comment from @yosifkit is applicable for this PR as well:
|
|
Yes, good point @Starefossen. I'm 👎 on this. This change doesn't seem necessary. |
|
Sorry, i was following example of other core docket images. Didn't see these drawback |
|
No worries! |
No description provided.