-
Notifications
You must be signed in to change notification settings - Fork 2k
Update Node 10 Alpine version #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update from 3.8 to 3.9 Signed-off-by: Gari Singh <gari.r.singh@gmail.com>
|
We can merge this after the upcoming security release, I think. /cc @nodejs/docker |
|
@SimenB we usually wait for a new Node version to avoid breaking builds etc. |
|
I know, but I don't think an OS upgrade should be bundled with a security update |
|
@SimenB yeah, I think it should be the one after the security update? |
PeterDaveHello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we will deliver that with a regular release?
|
fyi we had some failed builds today because of this change, some native add-ons we use failed building and some apk dependencies were not found after upgrading to v10.15.3 because of the Alpine version bump. |
|
We've had some issues with curl and SSL since this release. |
|
cc @nodejs/docker ⬆️ |
|
Would that be because of the new version of Alpine? |
|
@LaurentGoderre most probably, yes |
Closes #998
Given Node 10 is the current LTS, it makes sense to move to Alpine 3.9. Node 11 images are already using 3.9 as well.