This repository was archived by the owner on Jul 6, 2018. It is now read-only.
http2: edge case errors, consistency, nits #167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Pushed a few more changes.
|
Contributor
Author
|
Added:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…Response This avoids brittle abstraction-leaking to guess whether or not ServerHttp2Stream.respond() may still be called on HEAD requests where the stream is ended before headers are sent.
sebdeckers
force-pushed
the
compat-respond-with-file
branch
from
1eec6da to
64376eb
Compare
Contributor
Author
|
@jasnell De-linted. Welcome back! 👋 |
2 tasks
4 tasks
jasnell
pushed a commit
that referenced
this pull request
Jul 13, 2017
* edge case errors, consistency, nits * ServerHttp2Stream.headersSent property, proxied by Http2ServerResponse This avoids brittle abstraction-leaking to guess whether or not ServerHttp2Stream.respond() may still be called on HEAD requests where the stream is ended before headers are sent. * docs for ServerHttp2Stream headersSent & pushAllowed (Squash) * var to const/let * consistent log message prefix * doc fix & test for http2.connect() optional arguments * eslint object-curly-spacing: ["error", "always"] (Squash) PR-URL: #167 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed! |
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
* edge case errors, consistency, nits * ServerHttp2Stream.headersSent property, proxied by Http2ServerResponse This avoids brittle abstraction-leaking to guess whether or not ServerHttp2Stream.respond() may still be called on HEAD requests where the stream is ended before headers are sent. * docs for ServerHttp2Stream headersSent & pushAllowed (Squash) * var to const/let * consistent log message prefix * doc fix & test for http2.connect() optional arguments * eslint object-curly-spacing: ["error", "always"] (Squash) PR-URL: nodejs#167 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered these while working with everyone's new favourite API,
res.respondWithFile. 😉console.logintest-http2-respond-file.js. /cc @jasnellres.end(cb)callback behave the same as http1 (only fires the first time). Also no errors thrown on repeatedres.end()calls.res.stream.respondWithFilefrom the compatibility layer. Seems like a valid use-case (well, I'm using it 🤣).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2