[WIP] src: v8 snapshot command
#199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Neat! Just in case, you may find this helpful: https://github.com/indutny/core2dump (if it is still relevant) |
Contributor
Author
|
I found indutny/core2dump when working on this, but couldn't make it work :( (probably because so many things have changed in V8 in the last two years) |
Member
|
It would be cool to be able to expose a |
Contributor
Author
|
Closing since I haven't had the time to move this forward. If anyone wants to work on it, feel free to pick it up! (Although I think this will be much easier to accomplish once our JS API is out of experimental). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT LAND YET
[P.S.: The code is a mess right now, I'm opening a PR to get feedback on how the feature should look like]
This PR introduces a new command to create a V8 snapshot from a core dump. Right now the snapshot is not fully functional, but it works on Chrome DevTools. The goal is to enable the use of Chrome DevTools alongside llnode.
We still need to address #195 and #197 before making it work properly. Right now it can be used with the command
v8 snapshot, which will create acore.heapsnapshotin the current working directory. The generated file can be open by Chrome DevTools, but it doesn't show a list of retainers yet.