Skip to content

2021-10-12 notes #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeoffreyBooth merged 2 commits into from
Oct 20, 2021
Merged

2021-10-12 notes #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aaf1db
2021-10-12
GeoffreyBooth Oct 12, 2021
e4a0b78
Update doc/meetings/2021-10-12.md
GeoffreyBooth Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions doc/meetings/2021-10-12.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Node.js Loaders Team Meeting 2021-10-12

## Links

* **Recording**: https://www.youtube.com/watch?v=hxaFpjKy84E
* **GitHub Issue**: https://github.com/nodejs/loaders/issues/40

## Present

* Geoffrey Booth: @GeoffreyBooth
* Antoine du Hamel: @aduh95
* Jacob Smith: @JakobJingleheimer
* Myles Borins: @MylesBorins
* Bradley Farias: @bmeck

## Agenda

* module: unflag import assertions [#40250](https://github.com/nodejs/node/pull/40250)

## Notes

Discussion over whether assertion should be part of the module cache key or not, and consequences of one way or the other. @GeoffreyBooth will try to implement an approach where the assertions are part of the module _job,_ and checking the assertions will happen at the same time as the URL (key) is compared, effectively making it a combined key while still having one job per key. Open question of what to do when a mismatch is found. Will investigate in the open PR, and can even land with a tentative solution that can change later since JSON modules are still flagged and this is an edge case that should never happen in realistic code (two import statements resolving to the same URL, with different assertions).