`import *` broken?

[lheckemann]

I've been having odd issues with my testing setup; I don't fully understand the problem, and haven't been able to reproduce it outside of a nix build, but I've been able to bisect the issue down to nodejs/node@68da144.

Unfortunately, I haven't been able to pare this down to a minimal reproducer, nor can I share the full project; I'm running firefox playwright tests against a project built with vite, and the breakage seems to boil down to a difference in how import * behaves in the code built by vite running in the browser, which seems pretty cursed!

My import looks like this:

import * as Chord from "@tonaljs/chord"

My code then uses Chord.get(), which works fine prior to this change and breaks afterwards with "Chord.get is not a function".

Logging the imported Chord object shed some light on the problem:

[Module: null prototype] {                                                                                                                                                                 
  chord: [Function (anonymous)],                                                                                                                                                           
  chordScales: [Function: chordScales],       
  default: {                                  
    chord: [Getter],                                                                                                                                                                       
    chordScales: [Getter],                                                                   
    default: [Getter],                        
    degrees: [Getter],                                                                       
    deprecate: [Getter],                                                                     
    detect: [Getter],                                                                        
    extended: [Getter],                                                                                                                                                                    
    get: [Getter],                                                                                                                                                                         
    getChord: [Getter],                                                                                                                                                                    
    reduced: [Getter],                                                                                                                                                                     
    steps: [Getter],                                                                                                                                                                       
    tokenize: [Getter],                                                                                                                                                                    
    transpose: [Getter]                                                                      
  },                                                                                                                                                                                       
  degrees: [Function: degrees],                                                                                                                                                            
  deprecate: [Function: deprecate],                                                                                                                                                        
  detect: [Function: detect],                                                                
  extended: [Function: extended],                                                            
  'module.exports': {                                                                        
    chord: [Getter],                                                                         
    chordScales: [Getter],                                                                                                                                                                 
    default: [Getter],                        
    degrees: [Getter],                                                                       
    deprecate: [Getter],                                                                     
    detect: [Getter],                                                                        
    extended: [Getter],                                                                                                                                                                    
    get: [Getter],                                                                                                                                                                         
    getChord: [Getter],                                                                                                                                                                    
    reduced: [Getter],                        
    steps: [Getter],                                                                         
    tokenize: [Getter],                                                                      
    transpose: [Getter]                                                                      
  }                                           
}          

so somehow module.exports isn't exposed directly anymore?

If anyone has any idea how this might be happening, it would be much appreciated!

[anonrig]

Can you share the contents of the imported file? Also do you have a minimum reproduction

[lheckemann]

OK, I now have managed to reproduce it.

https://sphalerite.org/dump/merve-49-repro.tar.gz

[linus@elder:~/bla]$ /tmp/node-builds/30601b680fe33330bf5033bc433160d48fedcd2d/bin/node test.js
[Module: null prototype] {
  chord: [Function: get],
  chordScales: [Function: chordScales],
  default: {
    chord: [Getter],
    chordScales: [Getter],
    default: [Getter],
    degrees: [Getter],
    detect: [Getter],
    extended: [Getter],
    get: [Getter],
    getChord: [Getter],
    notes: [Getter],
    reduced: [Getter],
    steps: [Getter],
    tokenize: [Getter],
    transpose: [Getter]
  },
  degrees: [Function: degrees],
  detect: [Function: detect],
  extended: [Function: extended],
  get: [Function: get],
  getChord: [Function: getChord],
  'module.exports': {
    chord: [Getter],
    chordScales: [Getter],
    default: [Getter],
    degrees: [Getter],
    detect: [Getter],
    extended: [Getter],
    get: [Getter],
    getChord: [Getter],
    notes: [Getter],
    reduced: [Getter],
    steps: [Getter],
    tokenize: [Getter],
    transpose: [Getter]
  },
  notes: [Function: notes],
  reduced: [Function: reduced],
  steps: [Function: steps],
  tokenize: [Function: tokenize],
  transpose: [Function: transpose]
}

[linus@elder:~/bla]$ node test.js
[Module: null prototype] {
  chord: [Function: get],
  chordScales: [Function: chordScales],
  default: {
    chord: [Getter],
    chordScales: [Getter],
    default: [Getter],
    degrees: [Getter],
    detect: [Getter],
    extended: [Getter],
    get: [Getter],
    getChord: [Getter],
    notes: [Getter],
    reduced: [Getter],
    steps: [Getter],
    tokenize: [Getter],
    transpose: [Getter]
  },
  degrees: [Function: degrees],
  detect: [Function: detect],
  extended: [Function: extended],
  'module.exports': {
    chord: [Getter],
    chordScales: [Getter],
    default: [Getter],
    degrees: [Getter],
    detect: [Getter],
    extended: [Getter],
    get: [Getter],
    getChord: [Getter],
    notes: [Getter],
    reduced: [Getter],
    steps: [Getter],
    tokenize: [Getter],
    transpose: [Getter]
  }
}
file:///home/linus/bla/test.js:4
Chord.get("A")
      ^

TypeError: Chord.get is not a function
    at file:///home/linus/bla/test.js:4:7
    at ModuleJob.run (node:internal/modules/esm/module_job:430:25)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:661:26)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:101:5)

Node.js v24.13.2-pre

[lheckemann]

So maybe this is actually specific to items named get*?