Remove unnecessary local variable declaration #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bnoordhuis
approved these changes
Oct 4, 2019
Collaborator
|
Seems alright to me as well. Do not know why it was like that in the first place. I will merge.
…On October 4, 2019 7:59:56 PM GMT+03:00, legendecas ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#870
-- Commit Summary --
* Remove unnecessary local variable declaration
-- File Changes --
M nan.h (10)
-- Patch Links --
https://github.com/nodejs/nan/pull/870.patch
https://github.com/nodejs/nan/pull/870.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#870
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node-addon-api#529 (comment)
npm testpassed