CI test failures on Windows

[gabrielschulhof]

We've been having some issues with Windows 10, especially when building against v8.x:

On the machines below, there is a consistent failure to remove a directory because one of the files is being used by a process, ultimately resulting in failure:

test-rackspace-win2012r2_vs2019-x64-6
test-rackspace-win2012r2_vs2019-x64-1
test-rackspace-win2012r2_vs2019-x64-3
test-rackspace-win2012r2_vs2019-x64-2

cc @nodejs/build ... ?

[gabrielschulhof]

C:\workspace\node-test-node-addon-api-new\nodes\win-vs2019>rmdir C:\workspace\node-test-node-addon-api-new\nodes\win-vs2019 /s /q 
The process cannot access the file because it is being used by another process.

[gabrielschulhof]

Maybe we need some Windows equivalent of

killall some_relevant_process

before we do the rmdir?

[richardlau]

Not sure about the rmdir failures.
cc @joaocgreis

As for failures with Node.js 8 see: nodejs/build#2084 (comment)

PR to exclude Visual Studio 2019 from Node.js < 10 (since Node.js 8 ships with an older npm/node-gyp): nodejs/build#2085

[gms1]

C:\workspace\node-test-node-addon-api-new\nodes\win-vs2019>rmdir C:\workspace\node-test-node-addon-api-new\nodes\win-vs2019 /s /q 
The process cannot access the file because it is being used by another process.

I've had to deal with such errors many times; sometimes these are caused by virus scanners, sometimes by asynchronous behaviour (on network drives), but in this case it is probably caused by trying to remove the current working directory :-)

[mhdawson]

@gabrielschulhof and I worked through this during Node+JS Interactive and we believe we updated the job to avoid the problem. Believe it was a result of not having removed a command that did not seem to do anything on WIndows. Now it is cased out and looks like we've had good results since. Closing.