Skip to content

doc: document object iterators#1090

Merged
mhdawson merged 1 commit intonodejs:mainfrom
RaisinTen:doc/document-object-iterators
Oct 25, 2021
Merged

doc: document object iterators#1090
mhdawson merged 1 commit intonodejs:mainfrom
RaisinTen:doc/document-object-iterators

Conversation

@RaisinTen
Copy link
Copy Markdown
Member

Signed-off-by: Darshan Sen darshan.sen@postman.com

@RaisinTen
Copy link
Copy Markdown
Member Author

cc @NickNaso I've followed the suggestions you've left in #930 (review) :)

Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Copy Markdown
Member

@RaisinTen thanks for creating this follow up PR.

Copy link
Copy Markdown
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, just few notes.

Comment thread doc/object.md Outdated
Comment thread doc/object.md Outdated
Comment thread doc/object.md Outdated
Comment thread doc/object.md Outdated
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the doc/document-object-iterators branch from a4d851c to dfe39ee Compare October 15, 2021 15:12
@RaisinTen
Copy link
Copy Markdown
Member Author

@NickNaso thanks, updated accordingly :)

@RaisinTen RaisinTen requested a review from NickNaso October 15, 2021 15:13
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 0dfa89f into nodejs:main Oct 25, 2021
@RaisinTen RaisinTen deleted the doc/document-object-iterators branch October 26, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants