src, test: Add test covg for AsyncWorker and removing move copy/assignment operators #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode-addon-api into add-test-covg-for-async-workers
Closed
mhdawson
pushed a commit
that referenced
this pull request
Jan 30, 2023
- Remove AsyncWorker move operators. These cannot work properly due to the linkage between the node-api and node-addon-api components - Complete async worker test coverage for recv PR-URL: #1266 Reviewed-By: Michael Dawson <midawson@redhat.com
Member
|
Landed as e272619 |
This was referenced Jan 30, 2023
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
- Remove AsyncWorker move operators. These cannot work properly due to the linkage between the node-api and node-addon-api components - Complete async worker test coverage for recv PR-URL: nodejs/node-addon-api#1266 Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes both #1258 and #946