Skip to content

Make CallbackInfo cast to napi_callback_info explicit #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KevinEady wants to merge 2 commits into from
Closed

Make CallbackInfo cast to napi_callback_info explicit #1275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bfe93f
make operator napi_callback_info explicit
KevinEady Jan 18, 2023
afbd2c6
Merge branch 'nodejs:main' into fix-callback-info-cast-operator
KevinEady Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion napi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,7 +1794,7 @@ class CallbackInfo {
Value This() const;
void* Data() const;
void SetData(void* data);
operator napi_callback_info() const;
explicit operator napi_callback_info() const;

private:
const size_t _staticArgCount = 6;
Expand Down