doc: update class hierarchy for TypeTaggable#1303
Closed
gabrielschulhof wants to merge 2 commits intonodejs:mainfrom
Closed
doc: update class hierarchy for TypeTaggable#1303gabrielschulhof wants to merge 2 commits intonodejs:mainfrom
gabrielschulhof wants to merge 2 commits intonodejs:mainfrom
Conversation
Reflect in the class hierarchy that `Napi::TypeTaggable` was injected between `Napi::Object` and `Napi:External`, and their parent class, `Napi::Value`.
gabrielschulhof
force-pushed
the
update-class-hierarchy
branch
from
cb903be to
6335265
Compare
NickNaso
approved these changes
Mar 30, 2023
legendecas
approved these changes
Mar 31, 2023
gabrielschulhof
added a commit
that referenced
this pull request
Mar 31, 2023
Reflect in the class hierarchy that `Napi::TypeTaggable` was injected between `Napi::Object` and `Napi:External`, and their parent class, `Napi::Value`. PR-URL: #1303 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
Contributor
Author
|
Landed in 164459c. |
gabrielschulhof
added a commit
to gabrielschulhof/node-addon-api
that referenced
this pull request
Apr 1, 2023
Reflect in the class hierarchy that `Napi::TypeTaggable` was injected between `Napi::Object` and `Napi:External`, and their parent class, `Napi::Value`. PR-URL: nodejs#1303 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Reflect in the class hierarchy that `Napi::TypeTaggable` was injected between `Napi::Object` and `Napi:External`, and their parent class, `Napi::Value`. PR-URL: nodejs/node-addon-api#1303 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflect in the class hierarchy that
Napi::TypeTaggablewas injected betweenNapi::ObjectandNapi:External, and their parent class,Napi::Value.