Add memory mangament feature#286
Closed
NickNaso wants to merge 2 commits intonodejs:masterfrom
NickNaso:memory-management
Closed
Add memory mangament feature#286NickNaso wants to merge 2 commits intonodejs:masterfrom NickNaso:memory-management
NickNaso wants to merge 2 commits intonodejs:masterfrom
NickNaso:memory-management
Conversation
For more info see the following issue: #260
Contributor
gabrielschulhof
left a comment
gabrielschulhof
left a comment
There was a problem hiding this comment.
LGTM with these minor changes.
| ### AdjustExternalMemory | ||
|
|
||
| The function `AdjustExternalMemory` adjusts the amount of registered external | ||
| memory. Used to give the JavaScript engine an indication of the amount of externally |
Contributor
There was a problem hiding this comment.
"[It is ]Uused ..."
| static int64_t MemoryManagement::AdjustExternalMemory(Env env, int64_t change_in_bytes); | ||
| ``` | ||
|
|
||
| - `[in] env`: The environment in which the API is inoked under. |
| Object exports = Object::New(env); | ||
| exports["externalAllocatedMemory"] = Function::New(env, externalAllocatedMemory); | ||
| return exports; | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Please add a newline to the end of the file!
|
|
||
| function test(binding) { | ||
| assert.strictEqual(binding.memory_management.externalAllocatedMemory(), true) | ||
| } No newline at end of file |
Member
|
Landed as 605aa2b |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Add memory mangament feature For more info see the following issue: nodejs/node-addon-api#260 PR-URL: nodejs/node-addon-api#286 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Add memory mangament feature For more info see the following issue: nodejs/node-addon-api#260 PR-URL: nodejs/node-addon-api#286 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Add memory mangament feature For more info see the following issue: nodejs/node-addon-api#260 PR-URL: nodejs/node-addon-api#286 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Add memory mangament feature For more info see the following issue: nodejs/node-addon-api#260 PR-URL: nodejs/node-addon-api#286 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
MemoryManagementas class andAdjustExternalMemoryfunction as static method.For more info see the following issue: #260