Some fix on documentation and added new section dedicated to prebuild tools#353
Closed
NickNaso wants to merge 7 commits intonodejs:masterfrom
NickNaso:bigint-dataview
Closed
Some fix on documentation and added new section dedicated to prebuild tools#353NickNaso wants to merge 7 commits intonodejs:masterfrom NickNaso:bigint-dataview
NickNaso wants to merge 7 commits intonodejs:masterfrom
NickNaso:bigint-dataview
Conversation
…ols. Fix typo Fixed broken links
NickNaso
changed the title
mhdawson
reviewed
Sep 26, 2018
| The end-user will need to compile the add-on when they will do an `npm install` | ||
| and in some cases this could create problems. To avoid the compilation process it's | ||
| possible to ditribute the native add-on in pre-built form for different platform | ||
| and architecture. The prebuild tools help to create and distrubute the pre-built |
mhdawson
reviewed
Sep 26, 2018
mhdawson
reviewed
Sep 26, 2018
mhdawson
pushed a commit
that referenced
this pull request
Sep 28, 2018
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: #353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed as 51ffe45 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: nodejs/node-addon-api#353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: nodejs/node-addon-api#353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: nodejs/node-addon-api#353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: nodejs/node-addon-api#353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I fixed some inconsistencies over the
Napi::BigIntandNapi::DataViewdocumentation, then I added a new section called pre build tools where I tried to briefly explain what is a pre build tool and why it's important use one of them.Please review.