Implement CallbackScope class#362
Closed
romandev wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Contributor
Author
|
If someone has a permission, please add |
Member
|
@romandev thanks for picking this up :) |
romandev
force-pushed
the
callback_scope
branch
from
cdca219 to
d60a593
Compare
romandev
changed the title
romandev
force-pushed
the
callback_scope
branch
from
d60a593 to
4adf148
Compare
Contributor
Author
NickNaso
approved these changes
Oct 15, 2018
Member
NickNaso
left a comment
NickNaso
left a comment
There was a problem hiding this comment.
LGTM just few suggestion for documentation.
| ``` | ||
|
|
||
| - `[in] env`: The environment in which to create the `Napi::CallbackScope`. | ||
| - `[in] scope`: pre-existing `napi_callback_scope` or `Napi::CallbackScope`. |
Member
There was a problem hiding this comment.
pre-existing -> The pre-existing
| ``` | ||
|
|
||
| - `[in] env`: The environment in which to create the `Napi::CallbackScope`. | ||
| - `[in] async_context`: pre-existing `napi_async_context` or `Napi::AsyncContext`. |
Member
There was a problem hiding this comment.
pre-existing -> The pre-existing
This is a wrapper class to support the following N-APIs. - napi_open_callback_scope() - napi_close_callback_scope() Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope
romandev
force-pushed
the
callback_scope
branch
from
4adf148 to
579e865
Compare
Contributor
Author
|
Addressed your comments. Thank you for review! |
Contributor
Author
|
Could you please remove |
mhdawson
pushed a commit
that referenced
this pull request
Oct 22, 2018
This is a wrapper class to support the following N-APIs. - napi_open_callback_scope() - napi_close_callback_scope() Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope PR-URL: #362 Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Member
|
Landed as 405f3e5 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
This is a wrapper class to support the following N-APIs. - napi_open_callback_scope() - napi_close_callback_scope() Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope PR-URL: nodejs/node-addon-api#362 Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
This is a wrapper class to support the following N-APIs. - napi_open_callback_scope() - napi_close_callback_scope() Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope PR-URL: nodejs/node-addon-api#362 Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
This is a wrapper class to support the following N-APIs. - napi_open_callback_scope() - napi_close_callback_scope() Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope PR-URL: nodejs/node-addon-api#362 Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
This is a wrapper class to support the following N-APIs. - napi_open_callback_scope() - napi_close_callback_scope() Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope PR-URL: nodejs/node-addon-api#362 Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a wrapper class to support the following N-APIs.
Refs: https://nodejs.org/api/n-api.html#n_api_napi_open_callback_scope