Fix off-by-one error for strings of certain sizes#47
Merged
jasongin merged 1 commit intonodejs:masterfrom May 25, 2017
Merged
Conversation
Resizing a std::string to the number of chars to be copied into it usually worked because of how std::string usually allocates a little more memory than what is requested. But sometimes there would be no extra capacity, so the capacity() value passed to napi_get_value_string() was too short by one (due to the null-terminator). The result was strings of certain lengths could have one char trimmed off the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resizing a
std::stringto the number of chars to be copied into it usually worked because of howstd::stringusually allocates a little more memory than what is requested. But sometimes there would be no extra capacity, so thecapacity()value passed tonapi_get_value_string()was too short by one (due to the null-terminator). The result was strings of certain lengths could have one char trimmed off the end.