src: attach data with napi_add_finalizer #577
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
legendecas
approved these changes
Oct 28, 2019
Member
|
CI failure could be addressed by #576. |
Use `napi_add_finalizer()` to attach data when building against N-API 5 instead of the symbol + external approach that leaves a trace on the target object. Fixes: nodejs#557
gabrielschulhof
force-pushed
the
issue-557
branch
from
d484d03 to
301c5bf
Compare
Contributor
Author
Contributor
Author
|
Landed in bdfd141. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Use `napi_add_finalizer()` to attach data when building against N-API 5 instead of the symbol + external approach that leaves a trace on the target object. Fixes: nodejs/node-addon-api#557 PR-URL: nodejs/node-addon-api#577 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Use `napi_add_finalizer()` to attach data when building against N-API 5 instead of the symbol + external approach that leaves a trace on the target object. Fixes: nodejs/node-addon-api#557 PR-URL: nodejs/node-addon-api#577 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Use `napi_add_finalizer()` to attach data when building against N-API 5 instead of the symbol + external approach that leaves a trace on the target object. Fixes: nodejs/node-addon-api#557 PR-URL: nodejs/node-addon-api#577 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Use `napi_add_finalizer()` to attach data when building against N-API 5 instead of the symbol + external approach that leaves a trace on the target object. Fixes: nodejs/node-addon-api#557 PR-URL: nodejs/node-addon-api#577 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
napi_add_finalizer()to attach data when building against N-API 5instead of the symbol + external approach that leaves a trace on the
target object.
Fixes: #557