Skip to content

gyp: fix gypfile name in index.js #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

gyp: fix gypfile name in index.js #658

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Jan 24, 2020

Refs: #643

NickNaso
NickNaso approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Jan 30, 2020

CI:

Version Job Status
v14.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1698/ ✓
v12.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1699/ ✓
v10.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1670/ ✓

gabrielschulhof pushed a commit that referenced this pull request Jan 30, 2020
@addaleax
gyp: fix gypfile name in index.js
7ac6e21 
Refs: #643
PR-URL: #658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Jan 30, 2020

Landed in 7ac6e21.

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
gyp: fix gypfile name in index.js
9ddb06e 
Refs: nodejs/node-addon-api#643
PR-URL: nodejs/node-addon-api#658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
gyp: fix gypfile name in index.js
c20af78 
Refs: nodejs/node-addon-api#643
PR-URL: nodejs/node-addon-api#658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
gyp: fix gypfile name in index.js
9a311f0 
Refs: nodejs/node-addon-api#643
PR-URL: nodejs/node-addon-api#658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
gyp: fix gypfile name in index.js
928b339 
Refs: nodejs/node-addon-api#643
PR-URL: nodejs/node-addon-api#658
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickNaso NickNaso NickNaso approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@addaleax @gabrielschulhof @NickNaso @mhdawson