build: fix ARM build #265

kfarnung · 2017-05-26T05:40:52Z

Several fixes needed:

Don't pass in the platform to ChakraCore-
it'll figure out the right SDK version
Disable intl on ARM if cross-compiling
Set the default SDK version if compiling ARM to
be v10.0 since Node doesn't seem to compile for
Windows on ARM with the older SDKs.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

build

kfarnung · 2017-05-26T05:41:26Z

Thanks @digitalinfinity for finishing this change up!

digitalinfinity · 2017-05-26T16:52:50Z

LGTM- @nodejs/platform-windows does the change in msvs.py look ok? Should we move that to upstream? It's not a problem in upstream generally since I don't believe regular Node.js supports compiling for Windows on ARM, but I'm curious where the right place to land that change is.

refack · 2017-05-26T17:28:25Z

I'm -0.5 for patching GYP would suggest patching configure

refack · 2017-05-26T17:32:57Z

https://github.com/nodejs/node-chakracore/blob/xplat/configure#L765
Not sure what would would work:
probably o['target_defaults']['msvs_windows_sdk_version'] = 'v10.0'
or o['variables']['msvs_windows_sdk_version'] = 'v10.0'

refack · 2017-05-26T17:39:36Z

vcbuild.bat

+if "%target_arch%"=="arm" (
+  if "%PROCESSOR_ARCHITECTURE%" NEQ "ARM" (
+    echo Skipping building ARM with Intl on a non-ARM device
+    set configure_flags=%configure_flags% --without-intl


[FYI]
--without-intl will disable the inspector nodejs/node#12978
Not sure what's the equivalent for chakra, but all the #if HAVE_INSPECTOR code section will be off

Thanks @refack, I filed #268 to explore whether we can support building ICU in the build machine's architecture and hopefully re-enable it. For now we'll just have to keep the lack of inspector as a known issue.

refack · 2017-05-26T17:40:32Z

tools/gyp/pylib/gyp/generator/msvs.py

+  # Node for Windows on ARM requires at least the Windows 10 SDK
+  # to build. If it hasn't already been provided, set the default
+  # to v10.0
+  if "msvs_windows_sdk_version" not in configuration:


Should move to configure as per my comment.

digitalinfinity · 2017-05-26T18:23:25Z

@refack ah, so that was the magic configure incantation! I think a case can still be made for making the change in gyp in case anyone else using gyp runs into it, but I don't feel too strongly and I think for our purposes, a configure change works better since I don't want node-chakracore's gyp to diverge from upstream. @kfarnung I verified that digitalinfinity@1fdbbd4 builds fine on my Windows machine with ARM- feel free to cherry-pick into your PR.

refack · 2017-05-26T18:35:33Z

I think a case can still be made for making the change in gyp in case anyone else using gyp runs into it

I'd agree but GYP attempts to be all-knowing-all-detecting so for pushing this upstream (GYP upstream that is) you'll need to add some detection logic instead of the "arbitrary" v10.0 value... (https://github.com/kfarnung/node-chakracore/blob/c6f78a5176324cf1a0e861f103392b653059f408/tools/gyp/pylib/gyp/generator/msvs.py#L297)

kfarnung · 2017-05-26T22:13:46Z

@refack @digitalinfinity I'm not able to confirm in CI yet, but I've incorporated your recommendations and rebased against xplat.

refack · 2017-05-26T22:15:03Z

configure

  o['variables']['arm_fpu'] = options.arm_fpu or arm_fpu

+  if flavor == 'win':
+    o['msvs_windows_sdk_version'] = 'v10.0'


~~Should be o['target_defaults']['msvs_windows_sdk_version']~~

configure_arm is called from configure_node which is called from configure_engine (https://github.com/nodejs/node-chakracore/blob/xplat/configure#L1338). At the point configure_engine is called, output['target_defaults'] hasn't been defined yet- it gets defined later at https://github.com/nodejs/node-chakracore/blob/xplat/configure#L1376. So it looks like the way to get it propagated from configure_arm is to set the property directly on o here? Or did I misunderstand something?

Yep you are right.

There's just a wierd hack at https://github.com/nodejs/node-chakracore/blob/xplat/configure#L1355 for the ['variables'] that always confuses me

Haha yeah, I got thrown off by that too- it seemed like a roundabout way to do things 😄

digitalinfinity

Thanks @joaocgreis for triggering the test build: https://nodejs.org/download/test/v8.0.0-test201705267e3babf033/

Given that the arm build is unblocked, this PR is fine from my side

kfarnung · 2017-05-26T23:02:55Z

@refack look good to you?

joaocgreis · 2017-05-26T23:07:50Z

CI: https://ci.nodejs.org/view/All/job/chakracore-test-pull-request/58/

refack

LGTM (% CI as always)

kfarnung · 2017-05-26T23:36:18Z

Thanks for your help @refack!

Several fixes needed: 1. Don't pass in the platform to ChakraCore- it'll figure out the right SDK version 2. Disable intl on ARM if cross-compiling 3. Set the default SDK version if compiling ARM to be v10.0 since Node doesn't seem to compile for Windows on ARM with the older SDKs. PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

Several fixes needed: 1. Don't pass in the platform to ChakraCore- it'll figure out the right SDK version 2. Disable intl on ARM if cross-compiling 3. Set the default SDK version if compiling ARM to be v10.0 since Node doesn't seem to compile for Windows on ARM with the older SDKs. PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

Several fixes needed: 1. Don't pass in the platform to ChakraCore- it'll figure out the right SDK version 2. Disable intl on ARM if cross-compiling 3. Set the default SDK version if compiling ARM to be v10.0 since Node doesn't seem to compile for Windows on ARM with the older SDKs. PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

Several fixes needed: 1. Don't pass in the platform to ChakraCore- it'll figure out the right SDK version 2. Disable intl on ARM if cross-compiling 3. Set the default SDK version if compiling ARM to be v10.0 since Node doesn't seem to compile for Windows on ARM with the older SDKs. PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

kfarnung self-assigned this May 26, 2017

kfarnung requested review from digitalinfinity and kunalspathak May 26, 2017 05:40

kfarnung force-pushed the arm branch from 50b199d to c6f78a5 Compare May 26, 2017 16:28

kunalspathak approved these changes May 26, 2017

View reviewed changes

refack suggested changes May 26, 2017

View reviewed changes

kfarnung force-pushed the arm branch 2 times, most recently from cb8bd7f to 7e3babf Compare May 26, 2017 22:13

refack reviewed May 26, 2017

View reviewed changes

digitalinfinity approved these changes May 26, 2017

View reviewed changes

refack approved these changes May 26, 2017

View reviewed changes

kfarnung added 2 commits May 27, 2017 19:00

test: marking new flaky test

e35fd86

PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

kfarnung force-pushed the arm branch from 1217bd9 to e35fd86 Compare May 28, 2017 02:02

kfarnung merged commit e35fd86 into nodejs:xplat May 28, 2017

kfarnung deleted the arm branch May 28, 2017 02:02

kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 31, 2017

test: marking new flaky test

fd3212e

PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Jun 1, 2017

test: marking new flaky test

6c74fdd

PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Jun 5, 2017

test: marking new flaky test

157ff2c

PR-URL: nodejs#265 Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>

Uh oh!

build: fix ARM build #265

build: fix ARM build #265

Conversation

kfarnung commented May 26, 2017

Checklist

Affected core subsystem(s)

Uh oh!

kfarnung commented May 26, 2017

Uh oh!

digitalinfinity commented May 26, 2017

Uh oh!

refack commented May 26, 2017

Uh oh!

refack commented May 26, 2017

Uh oh!

refack May 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kfarnung May 26, 2017

Choose a reason for hiding this comment

Uh oh!

refack May 26, 2017

Choose a reason for hiding this comment

Uh oh!

digitalinfinity commented May 26, 2017

Uh oh!

refack commented May 26, 2017

Uh oh!

kfarnung commented May 26, 2017

Uh oh!

refack May 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

digitalinfinity May 26, 2017

Choose a reason for hiding this comment

Uh oh!

refack May 26, 2017

Choose a reason for hiding this comment

Uh oh!

refack May 26, 2017

Choose a reason for hiding this comment

Uh oh!

digitalinfinity May 26, 2017

Choose a reason for hiding this comment

Uh oh!

digitalinfinity left a comment

Choose a reason for hiding this comment

Uh oh!

kfarnung commented May 26, 2017

Uh oh!

joaocgreis commented May 26, 2017

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

kfarnung commented May 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

refack May 26, 2017 •

edited

Loading

refack May 26, 2017 •

edited

Loading