This repository was archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: add warning for ignored engine flags #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfarnung
commented
Mar 24, 2018
| startsWith(arg, "--nolazy") || | ||
| startsWith(arg, "--max-old-space-size=")) { | ||
| // Ignore some flags to reduce unit test noise | ||
| fprintf(stderr, "Warning: Ignored engine flag: %s\n", arg); |
Contributor
Author
There was a problem hiding this comment.
This doesn't seem to bother any of the unit tests, but I'll have to check that VS Code doesn't get upset about it (I doubt it). I'd say we either have a warning for all of these flags or none of them.
Contributor
Author
|
On Windows at least the > react-scripts-ts build
Failed to load tsconfig.json: Missing baseUrl in compilerOptions
Creating an optimized production build...
Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin
Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin
Warning: Unsupported engine flag:Starting type checking and linting service...
--Using m1 workera with x2048MB- memory limit
old-space-size=2048
ts-loader: Using typescript@2.7.2 and D:\Samples\my-app\tsconfig.json
Compiled successfully.
File sizes after gzip:
35.45 KB build\static\js\main.ceb68587.js
300 B build\static\css\main.29266132.css
The project was built assuming it is hosted at the server root.
To override this, specify the homepage in your package.json.
For example, add this to build it for GitHub Pages:
"homepage" : "http://myname.github.io/myapp",
The build folder is ready to be deployed.
You may serve it with a static server:
npm install -g serve
serve -s buildThe good news is that |
Contributor
Author
Contributor
Author
Contributor
Author
|
@mrkmarron @digitalinfinity I added an eslint ignore to trace_mgr.js due to a new rule about using |
The error created isn't ever thrown, it's just used to get an approximate stack. PR-URL: nodejs#502 Reviewed-By: Seth Brenith <sethb@microsoft.com>
* Added a warning for any ignored engine-specific flags. * Added `--max-old-space-size=` to the list of ignored flags. PR-URL: nodejs#502 Reviewed-By: Seth Brenith <sethb@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 28, 2018
* Added a warning for any ignored engine-specific flags. * Added `--max-old-space-size=` to the list of ignored flags. PR-URL: nodejs#502 Reviewed-By: Seth Brenith <sethb@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Apr 6, 2018
The error created isn't ever thrown, it's just used to get an approximate stack. PR-URL: nodejs#502 Reviewed-By: Seth Brenith <sethb@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--max-old-space-size=to the list of ignored flags.Fixes #486
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes