Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Oct 24, 2019

Most semver-major bumps are for dropping Node.js 6 support.

Most semver-major bumps are for dropping Node.js 6 support.
@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is 80.76%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   75.23%   75.23%           
=======================================
  Files          21       21           
  Lines        1409     1409           
=======================================
  Hits         1060     1060           
  Misses        349      349
Impacted Files Coverage Δ
lib/config.js 80.95% <ø> (ø) ⬆️
lib/auth.js 80.43% <0%> (ø) ⬆️
lib/team_info.js 92.15% <100%> (ø) ⬆️
lib/reviews.js 98.41% <100%> (ø) ⬆️
lib/pr_checker.js 96.33% <100%> (ø) ⬆️
lib/cache.js 100% <100%> (ø) ⬆️
lib/ci/ci_type_parser.js 80.95% <100%> (ø) ⬆️
lib/metadata_gen.js 100% <100%> (ø) ⬆️
lib/ci/ci_result_parser.js 46.06% <42.85%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7318d...267425b. Read the comment docs.

@targos
Copy link
Member Author

targos commented Oct 25, 2019

/cc @joyeecheung @priyank-p

Copy link
Contributor

@priyank-p priyank-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@targos targos merged commit 33666e1 into nodejs:master Oct 25, 2019
@targos targos deleted the update-deps branch October 25, 2019 18:51
@targos targos mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants