Skip to content

Conversation

@bipinct
Copy link

@bipinct bipinct commented Oct 31, 2017

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

gibfahn
gibfahn previously approved these changes Oct 31, 2017
@gibfahn
Copy link
Member

gibfahn commented Oct 31, 2017

@Bipin000 thanks for the PR

At the moment your commit is authored by:

So at the moment your Git author name and email address are set to:

bct <bipin.tripathi@ocharge.co.ke>

People usually choose to use their full names for commits. To set your name globally you can do:

git config --global user.name "Bipin Tripathi"
git config --global user.email "bipin.tripathi@ocharge.co.ke"

To change the author for a single commit you can do:

git commit --amend --author="Bipin Tripathi <bipin.tripathi@ocharge.co.ke>"
git push --force-with-lease

If you don't want to have your name against this commit, that's fine too.

@gibfahn
Copy link
Member

gibfahn commented Oct 31, 2017

Also it looks like your email isn't associated with your GitHub ID, which means GitHub won't credit you for the commit. To fix this go to https://github.com/settings/emails and add bipin.tripathi@ocharge.co.ke.

@gibfahn gibfahn mentioned this pull request Oct 31, 2017
4 tasks
@gibfahn
Copy link
Member

gibfahn commented Oct 31, 2017

Same comment as nodejs/node#16633 (comment), could you upstream this first?

@bipinct
Copy link
Author

bipinct commented Nov 1, 2017

@gibfahn thanks !! I have updated the email

@gibfahn gibfahn dismissed their stale review November 1, 2017 17:34

Should be upstreamed first.

@bipinct bipinct closed this Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants