Only add "-undefined dynamic_lookup" to loadable_module targets #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding "-undefined dynamic_lookup" to all targets makes it impossible to create Xcode projects with node-gyp for gyp files that also include "none" targets. Since non-targets don't have a framework phase, gyp errors when trying to add the link flag. In addition, "-undefined dynamic_lookup" should be added as a linker flag, not a link library, so it's now passed in the "OTHER_LDFLAGS" setting
TooTallNate
added a commit
that referenced
this pull request
May 19, 2015
Only add "-undefined dynamic_lookup" to loadable_module targets
Contributor
|
Thanks! |
TooTallNate
added a commit
to TooTallNate/node-ogg
that referenced
this pull request
May 24, 2015
Needed for node-gyp v2.0.0. See nodejs/node-gyp#612.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
-undefined dynamic_lookupto all targets makes it impossible to create Xcode projects with node-gyp for gyp files that also includenonetargets. Sincenonetargets don't have a framework phase, gyp errors when trying to add the link flag.In addition,
-undefined dynamic_lookupshould be added as a linker flag, not a link library, so it's now passed in theOTHER_LDFLAGSsetting.This also fixes #536.