This repository was archived by the owner on Feb 1, 2022. It is now read-only.
fix: Make --inspect-port=0 work #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selecting port zero makes the inspector bind to a random port. The inspector prints the URL it listens on to stderr. Parse the output from the child process to find the port number. This commit coincidentally also makes `node inspect --port=0 x.js` work and a regression test to that effect has been added. Note that connecting to an existing process that listens on a non-standard port with `node inspect -p <pid>` does not work because then we never see the output from the inspector. Fixes: nodejs/node#16469
Collaborator
|
Triggering CI and hoping there's no unconnected failure in recent node releases... https://ci.nodejs.org/view/x%20-%20Diagnostics/job/node-inspect-continuous-integration/41/ |
Collaborator
|
Triggering a master build to make sure the Windows failures are a general problem. Don't think that's connected to this PR. EDIT: Looks like a problem with the CI configuration for the Windows builds. Going to merge this change and try to figure out how to fix it independently. Maybe this is a good opportunity to invest into writing that Jenkinsfile. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting port zero makes the inspector bind to a random port.
The inspector prints the URL it listens on to stderr. Parse the
output from the child process to find the port number.
This commit coincidentally also makes
node inspect --port=0 x.jswork and a regression test to that effect has been added.
Note that connecting to an existing process that listens on a
non-standard port with
node inspect -p <pid>does not workbecause then we never see the output from the inspector.
Fixes: nodejs/node#16469