Transitioning to nodejs/node

[orangemocha]

Now that the converged https://github.com/nodejs/node is in place (nodejs/node#2327), we can work on moving this repo to the nodejs org, and the v0.x branches to the nodejs/node repo.

Moving v0.x branches to nodejs/node

Since we'll have PRs open in two repos, I suggest we transition to landing them in nodejs/node, but keep mirroring the status of those branches on the old repo.

Suggested procedure:

• Modify node-accept-commit (used internally by node-accept-pull-request), so that if a commit is merged into a v0.x branch in nodejs/node, it will force push the updated branch back to the old repo.
• Modify node-accept-pull-request so that if it is invoked on a PR in the old repo, it will push the change to a temporary ref on nodejs/node and then invoke node-accept-commit on it. Basically, this allows stil using node-accept-pull-request to land PRs that are open in the old repo.
• Disable node-accept-pull-request to make the following transition atomic
• Push v0.x branches to nodejs/node, including release tags. Should we also push release branches?
• Update the release guide to change references from joyent/node to nodejs/node
• Update the README in the old repo, to signify that this is now an archive of pre-convergence issues and PRs, and that new v0.x issues and PRs should be opened in nodejs/node.
• Make node-accept-commit fail if invoked directly on the old repo.
• Re-enable node-accept-pull-request and resume v0.x business as usual.
• If some one opens a new issue or PR on the old repo, we immediately close it and point them to the section of the README that tells them to open the same on nodejs/node. Unfortunately GitHub doesn't allow disabling new pull requests. We could try to automate this at some point if we feel it's worth it.

Moving joyent/node to nodejs/node-0.x-archive

After we move the branches to nodejs/node, this repo can serve as an archive for existing issues and PRs that are still relevant. And thanks to moving to the nodejs org, it will be easier to mention teams from that organization.

Suggested procedure:

• Rename joyent/node to joyent/node-v0.x-archive
• Transfer ownership to the nodejs org
• Merge collaborators and teams

I have verified that GitHub will redirect links from joyent/node to nodejs/node-0.x-archive.

Any preferences on the name of the transferred repo?

cc: @joyent/node-collaborators , @joyent/node-tsc

[jasnell]

👍 The plan sounds good.

[jasnell]

That said, we still have 750+ open issues that have yet to be fully resolved. We need to make sure those are not forgotten and get addressed at some point.

[rvagg]

Should we also push release branches?

If it's not too much trouble I don't see why not, I've written many scripts that depend on certain refs being available in a repo and if those were to disappear it would be a pain; so we should make transition as painless as possible so that folks only have to switch joyent/node to nodejs/node and it just works.

Any preferences on the name of the transferred repo?

"node-0.x-archive" sounds reasonable, if a little verbose

Merge collaborators and teams

From what I understand nodejs/node#2413 takes care of the remaining outstanding collaborator still to be onboarded. nodejs/node#2416 takes care of merging release processes/teams. Website teams should already be converged, docker teams are converging, are there other teams?

Otherwise lgtm fwiw.

[orangemocha]

Sure, porting release branches sounds good.

"node-0.x-archive" sounds reasonable, if a little verbose

Maybe node-v0.x-archive (with the additional v) would be better since it's more consistent with the branch names. One more letter of verbosity 😒 Perhaps we can drop the -archive part.

From what I understand nodejs/node#2413 takes care of the remaining outstanding collaborator still to be onboarded. nodejs/node#2416 takes care of merging release processes/teams. Website teams should already be converged, docker teams are converging, are there other teams?

Right, we'll just want to make sure that the teams after the move look the same as https://github.com/nodejs/node/settings/collaboration. That might mean deleting some collaborators/teams from the old repo.

Otherwise lgtm fwiw

I'll work on the CI changes.

[misterdjules]

@orangemocha Yes, release branches need to be pushed to nodejs/node.

Before renaming and moving the repository, we'll need to make sure that we can do v0.10.x and v0.12.x releases from nodejs/node. Is that the case already?

[orangemocha]

@misterdjules I was hoping that you could confirm that part 😄 The old Jenkins job is still in place for it. So is there any part of the release process that relies on the location of the repository?

[rvagg]

@misterdjules @orangemocha I have a new server set up for new.nodejs.org and I'm planning on doing some test runs on 0.1[02].x releases there when we get all the pieces in place. I agree re leaving things as they are until we can confirm this because we don't want to get caught with our pants down needing to do a security release and not being able to.

[orangemocha]

Ok, definitely won't touch anything until you guys can confirm that we can continue making releases.

[orangemocha]

I have prepared the CI changes and verified that the current release procedure does not depend in anyway on the location of the repo. In fact, most of the release is built using a personal fork of joyent/node. The only extra step (added to the above list) is to update the release guide to change references from joyent/node to nodejs/node.

Once the PR to update the readme gets approved, I will schedule to the move for the next day, and announce the time here.

@misterdjules @rvagg let me know if you have any objections.

[rvagg]

Cool, I'd like to discuss 0.10 and 0.12 releases in tomorrow/today's Build WG meeting, I've been thinking how we might be able to remove the requirement of a converged release procedure from getting v4 out without introducing any risks. But since both branches are ready for another release we should use those to get it all sorted out as soon as possible after v4.