This repository was archived by the owner on Apr 22, 2023. It is now read-only.
src: enable strict mode in all builtin modules#9302
Closed
misterdjules wants to merge 1 commit intonodejs:masterfrom
Closed
src: enable strict mode in all builtin modules#9302misterdjules wants to merge 1 commit intonodejs:masterfrom
misterdjules wants to merge 1 commit intonodejs:masterfrom
Conversation
This is a follow-up commit for b233131. It enables strict mode in all built-in modules.
Author
|
Tests started on UNICEs and on Windows. |
Author
|
/cc @joyent/node-coreteam. |
|
LGTM |
Member
|
/cc @mdawsonibm |
|
LGTM. |
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Mar 4, 2015
This is a follow-up commit for b233131. It enables strict mode in all built-in modules. PR: nodejs#9302 PR-URL: nodejs#9302 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Author
|
Thank you @cjihrig and @trevnorris for the review! Landed in ef43443. |
jasnell
pushed a commit
to jasnell/node-joyent
that referenced
this pull request
Mar 14, 2015
This is a follow-up commit for b233131. It enables strict mode in all built-in modules. PR: nodejs#9302 PR-URL: nodejs#9302 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up commit for b233131.
It enables strict mode in all built-in modules. This will break existing code, but the goal is to progressively fix as many issues as possible that can arise when using
--use-strict.It could probably break code that loads these modules within a browser, since any of the
'use strict';directive would turn all code into strict mode. I'm not sure how much we support this use case though, any information on that would be much appreciated.