This repository was archived by the owner on Apr 22, 2023. It is now read-only.
crypto: remove hoisted function#9316
Closed
vkarpov15 wants to merge 1 commit intonodejs:masterfrom
vkarpov15:fix-crypto-strict
Closed
crypto: remove hoisted function#9316vkarpov15 wants to merge 1 commit intonodejs:masterfrom vkarpov15:fix-crypto-strict
vkarpov15 wants to merge 1 commit intonodejs:masterfrom
vkarpov15:fix-crypto-strict
Conversation
|
Thanks for reporting this. This was recently fixed in #9237 |
Author
|
Thanks for fixing, much appreciated. Will this get backported to 0.10? |
|
@vkarpov15 As far as I know, this issue doesn't affect node v0.10.x. Did you encounter a similar problem with node v0.10.x? |
Author
|
Nope, I just didn't check 0.10. No further issues, thanks for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heya,
Re: Automattic/mongoose#2281, crypto and strict mode don't play nicely together:
This'll fix that particular issue