v8: include right headers in torque output

[gengjiawen]

Credits goes to @bnoordhuis , he does all the hard work. See #133.

I add one more line (4006).

    cc_contents << "#include \"src/objects/property-descriptor-object.h\"\n";

Verified on Visual Studio 2017 Developer Command Prompt v15.9.20.

Fix #128

[gengjiawen]

Is it possible we drop support vs2017 ? We seemed spend way too much time on it.

[richardlau]

Is it possible we drop support vs2017 ? We seemed spend way too much time on it.

I’d defer to @joaocgreis re. supported versions of VS.

[richardlau]

Credits goes to @bnoordhuis , he does all the hard work. See #133.

Add a Co-authored-by to the commit message?

[gengjiawen]

Credits goes to @bnoordhuis , he does all the hard work. See #133.

Add a Co-authored-by to the commit message?

Sure. I forced push the branch.

[targos]

Thanks.
So, I pushed it to canary-base in nodejs/node@a1066f0, but this should really be upstreamed at some point.

[joaocgreis]

Is it possible we drop support vs2017 ? We seemed spend way too much time on it.

I think on Node.js 14 it is still a bit too premature, but I'd have no objections for 15 or 16.

To be clear, this is for building Node.js core. For building add-ons, we should support it as long as possible.