Skip to content

Commit f2533b1

Browse files
bnoordhuisMylesBorins
authored andcommitted
Revert "src, tools: add debug symbols for node internals"
This reverts commit 446c1ec. Reverted for breaking `make test-v8`. The "find all relevant system headers" logic in `tools/gen-postmortem-metadata.py` needs more work. Also reverts commit e46c3f7. ("tools: fix typo in gen-postmortem-metadata.py".) PR-URL: #17272 Refs: #14901 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <matheusdot@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 118a3e2 commit f2533b1

File tree

2 files changed

+1
-225
lines changed

2 files changed

+1
-225
lines changed

node.gyp

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,6 @@
174174

175175
'dependencies': [
176176
'node_js2c#host',
177-
'deps/nghttp2/nghttp2.gyp:nghttp2'
178177
],
179178

180179
'includes': [
@@ -295,7 +294,6 @@
295294
# node.gyp is added to the project by default.
296295
'common.gypi',
297296
'<(SHARED_INTERMEDIATE_DIR)/node_javascript.cc',
298-
'<(SHARED_INTERMEDIATE_DIR)/node-debug-support.cc',
299297
],
300298

301299
'variables': {
@@ -967,29 +965,7 @@
967965
}]]
968966
}],
969967
]
970-
},
971-
{
972-
'target_name': 'node_postmortem_metadata',
973-
'type': 'none',
974-
'toolsets': ['host'],
975-
'actions': [
976-
{
977-
'action_name': 'gen-postmortem-metadata',
978-
'process_outputs_as_sources': 1,
979-
'inputs': [
980-
'./tools/gen-postmortem-metadata.py',
981-
],
982-
'outputs': [
983-
'<(SHARED_INTERMEDIATE_DIR)/node-debug-support.cc',
984-
],
985-
'action': [
986-
'python',
987-
'./tools/gen-postmortem-metadata.py',
988-
'<@(_outputs)',
989-
]
990-
}
991-
]
992-
},
968+
}
993969
], # end targets
994970

995971
'conditions': [

tools/gen-postmortem-metadata.py

Lines changed: 0 additions & 200 deletions
This file was deleted.

0 commit comments

Comments
 (0)