Revert "src, tools: add debug symbols for node internals" #17272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
danbev
approved these changes
Nov 23, 2017
bnoordhuis
commented
Nov 23, 2017
node.gyp
Outdated
Member
Author
There was a problem hiding this comment.
@mmarchini I don't quite understand why this was added. It doesn't seem to be used.
edit: ah, looks like #14901 partially undid 336af9a by accident.
Contributor
There was a problem hiding this comment.
This shouldn't be here, it was accidentally added when the branch was rebased
mmarchini
approved these changes
Nov 23, 2017
targos
approved these changes
Nov 23, 2017
joyeecheung
approved these changes
Nov 23, 2017
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
No new errors on the CI other than #17270
cjihrig
approved these changes
Nov 23, 2017
This reverts commit 446c1ec. Reverted for breaking `make test-v8`. The "find all relevant system headers" logic in `tools/gen-postmortem-metadata.py` needs more work. Also reverts commit e46c3f7. ("tools: fix typo in gen-postmortem-metadata.py".) PR-URL: nodejs#17272 Refs: nodejs#14901 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <matheusdot@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
bnoordhuis
force-pushed
the
revert-pr14901
branch
from
63d3976 to
088bba3
Compare
Member
Author
|
Thanks, landed in 088bba3 in < 48 hours to get the V8 CI back in working shape again. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
This reverts commit 446c1ec. Reverted for breaking `make test-v8`. The "find all relevant system headers" logic in `tools/gen-postmortem-metadata.py` needs more work. Also reverts commit e46c3f7. ("tools: fix typo in gen-postmortem-metadata.py".) PR-URL: #17272 Refs: #14901 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <matheusdot@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 446c1ec.
Reverted for breaking
make test-v8. The "find all relevant systemheaders" logic in
tools/gen-postmortem-metadata.pyneeds more work.Also reverts commit e46c3f7.
("tools: fix typo in gen-postmortem-metadata.py".)
CI: https://ci.nodejs.org/job/node-test-pull-request/11662/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1074/