Skip to content

Revert "src, tools: add debug symbols for node internals" #17272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 1 commit into from
Nov 23, 2017
Merged

Revert "src, tools: add debug symbols for node internals" #17272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@

'dependencies': [
'node_js2c#host',
'deps/nghttp2/nghttp2.gyp:nghttp2'
Copy link
Member Author

@bnoordhuis bnoordhuis Nov 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmarchini I don't quite understand why this was added. It doesn't seem to be used.

edit: ah, looks like #14901 partially undid 336af9a by accident.

Copy link
Contributor

@mmarchini mmarchini Nov 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here, it was accidentally added when the branch was rebased

],

'includes': [
Expand Down Expand Up @@ -299,7 +298,6 @@
# node.gyp is added to the project by default.
'common.gypi',
'<(SHARED_INTERMEDIATE_DIR)/node_javascript.cc',
'<(SHARED_INTERMEDIATE_DIR)/node-debug-support.cc',
],

'variables': {
Expand Down Expand Up @@ -972,29 +970,7 @@
}]]
}],
]
},
{
'target_name': 'node_postmortem_metadata',
'type': 'none',
'toolsets': ['host'],
'actions': [
{
'action_name': 'gen-postmortem-metadata',
'process_outputs_as_sources': 1,
'inputs': [
'./tools/gen-postmortem-metadata.py',
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/node-debug-support.cc',
],
'action': [
'python',
'./tools/gen-postmortem-metadata.py',
'<@(_outputs)',
]
}
]
},
}
], # end targets

'conditions': [
Expand Down
200 changes: 0 additions & 200 deletions tools/gen-postmortem-metadata.py
View file
Open in desktop

This file was deleted.