Path.normalize(undefined) throws on Mac but not on Windows

[bpasero]

Passing in "undefined" into Path.normalize() throws on Mac but works just fine on Windows. I think the issue is that Path.isAbsolute() does not check if path is null or undefined in https://github.com/iojs/io.js/blob/v1.x/lib/path.js#L440

[brendanashworth]

Can't confirm as I don't run windows (OSX does throw), but I'd certainly like to see some input verification here.

If you're interested, pull requests are welcome 😃

[silverwind]

Confirmed.

Windows:

$ iojs -p "require('path').normalize()"
undefined

OSX and Linux:

$ iojs -p "require('path').normalize()"
path.js:440
  return path.charAt(0) === '/';
             ^
TypeError: Cannot read property 'charAt' of undefined

[silverwind]

What's the expected result? undefined or a custom error perhaps?

[mscdex]

Or empty string?

[Fishrock123]

path.relative() throws TypeError: Arguments to path.resolve must be strings

(Most of the rest return '.')

[silverwind]

Probably best to throw TypeError in both posix.normalize and win32.normalize. The fact that normalize() returns undefined in win32 makes me a bit uneasy, but I don't think anyone would rely on that functionality, at least not knowingly, so I guess that would count as an bugfix, rather than an API change.

[Fishrock123]

Note: I did not notice earlier, but path.relative() only errors because path.resolve() does.

[piscisaureus]

I don't have an opinion on which behavior is better, but I'd certainly accept a patch that makes behavior consistent across platforms.

[cjihrig]

Throwing a TypeError if the input is not a string, sounds like the best bet.

[mscdex]

+1 for TypeError

[cjihrig]

Fixed in eb995d6