Skip to content

bootstrap: bootstrap should fail if ICU is misconfigured #13043

@refack

Description

@refack
  • Version: *
  • Platform: *
  • Subsystem: url,intl

Currently weird things happen if ICU is mis-configured

d:\code\node-cur$ set NODE_ICU_DATA=/

d:\code\node-cur$ node
> var url = require('url')
undefined
> url.parse('http://google.com')
Error: Cannot convert name to ASCII
    at Url.parse (url.js:317:23)
    at Object.urlParse [as parse] (url.js:75:5)
    at repl:1:5
    at ContextifyScript.Script.runInThisContext (vm.js:23:33)
    at REPLServer.defaultEval (repl.js:339:29)
    at bound (domain.js:280:14)
    at REPLServer.runBound [as eval] (domain.js:293:12)
    at REPLServer.onLine (repl.js:536:10)
    at emitOne (events.js:101:20)
    at REPLServer.emit (events.js:191:7)
>

Ref: nodejs/node-gyp#1199

Metadata

Metadata

Assignees

No one assigned

    Labels

    i18n-apiIssues and PRs related to the i18n implementation.lib / srcIssues and PRs related to general changes in the lib or src directory.urlIssues and PRs related to the legacy built-in url module.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions