Issues building test addons with both VS2015 and VS2017 installed #13641
Description
- Version: master
- Platform: windows
- Subsystem: test
After the upgrade of npm to 5.0.3 the addon tests started failing to build. I tracked it down to the node-gyp change nodejs/node-gyp@bad903ac70 by @refack. What I think is happening is that node-gyp now detects and tries to build with VS2017, but the node default build uses VS2015.
Details
gyp
info
using node-gyp@3.6.2
gyp
info
using
node@9.0.0-pre | win32 | x64
gyp
info
chdir test\addons\01_callbacks
gyp
info
spawn
C:\Python27\python.EXE
gyp
info
spawn args
[ 'E:\\GitHub\\node\\deps\\npm\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp
info
spawn args
'binding.gyp',
gyp
info
spawn args
'-f',
gyp info
spawn args
'msvs',
gyp
info
spawn args
'-G',
gyp
info
spawn args
'msvs_version=2015',
gyp
info
spawn args
'-I',
gyp
info
spawn args
'E:\\GitHub\\node\\test\\addons\\01_callbacks\\build\\config.gypi',
gyp
info spawn args
'-I',
gyp
info
spawn args
'E:\\GitHub\\node\\deps\\npm\\node_modules\\node-gyp\\addon.gypi',
gyp
info
spawn args
'-I',
gyp
info
spawn args
'E:\\GitHub\\node\\common.gypi',
gyp
info
spawn args
'-Dlibrary=shared_library',
gyp
info
spawn args
'-Dvisibility=default',
gyp
info
spawn args
'-Dnode_root_dir=E:\\GitHub\\node',
gyp info
spawn args
'-Dnode_gyp_dir=E:\\GitHub\\node\\deps\\npm\\node_modules\\node-gyp',
gyp
info
spawn args
'-Dnode_lib_file=E:\\GitHub\\node\\$(Configuration)\\node.lib',
gyp info
spawn args
'-Dmodule_root_dir=E:\\GitHub\\node\\test\\addons\\01_callbacks',
gyp
info
spawn args
'-Dnode_engine=v8',
gyp
info
spawn args
'--depth=.',
gyp
info
spawn args
'--no-parallel',
gyp
info
spawn args
'--generator-output',
gyp
info
spawn args
'E:\\GitHub\\node\\test\\addons\\01_callbacks\\build',
gyp
info
spawn args
'-Goutput_dir=.' ]
gyp
info spawn
msbuild
gyp
info
spawn args
[ 'build/binding.sln',
gyp
info
spawn args
'/clp:Verbosity=minimal',
gyp
info
spawn args
'/nologo',
gyp
info
spawn args
'/p:Configuration=Release;Platform=x64' ]
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.Cpp.Platform.targets(57,5): error MSB8020: The build tools for v141 (Platform Toolset = 'v141') cannot be found. To build using the v141 build tools, please install v141 build tools. Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [E:\GitHub\node\test\addons\01_callbacks\build\addon.vcxproj]
gyp
ERR!
build error
gyp
ERR!
stack
Error: `msbuild` failed with exit code: 1
gyp
ERR!
stack
at ChildProcess.onExit (E:\GitHub\node\deps\npm\node_modules\node-gyp\lib\build.js:258:23)
gyp
ERR!
stack
at emitTwo (events.js:125:13)
gyp ERR!
stack
at ChildProcess.emit (events.js:213:7)
gyp
ERR!
stack
at Process.ChildProcess._handle.onexit (internal/child_process.js:197:12)
gyp
ERR!
System
Windows_NT 10.0.16217
gyp
ERR!
command
"E:\\GitHub\\node\\Release\\node.exe" "E:\\GitHub\\node\\deps\\npm\\node_modules\\node-gyp\\bin\\node-gyp" "rebuild"
"--directory=test\\addons\\01_callbacks" "--nodedir=E:\\GitHub\\node"
gyp
ERR!
cwd
E:\GitHub\node\test\addons\01_callbacks
gyp
ERR!
node -v
v9.0.0-pre
gyp
ERR!
node-gyp -v
v3.6.2
gyp
ERR! not ok
After reverting the Win10SDK change, the build completes successfully. I was able to work around the issue by forcing the build to use VS2017:
vcbuild.bat vs2017 test
out.txt
config - before revert.txt
config - after revert.txt
[refack wrapped output in <details>]