-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Closed
Labels
docIssues and PRs related to the documentations.Issues and PRs related to the documentations.questionIssues that look for answers.Issues that look for answers.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
Description
tools/doc/package.jsonrequires"js-yaml": "^3.5.2":
Line 13 in 6fd8022
| "js-yaml": "^3.5.2" |
tools/doc/node_modules/js-yamlcontains only dummyindex.jswith reexport ofjs-yamlfrom ESLint dependency (so the version from the above-mentioned requirement cannot be checked anyway?):
node/tools/doc/node_modules/js-yaml/index.js
Lines 8 to 14 in 6fd8022
| const realJSYaml = path.resolve( | |
| __dirname, '..', '..', '..', // tools/ | |
| 'node_modules', | |
| 'eslint', | |
| 'node_modules', | |
| 'js-yaml' | |
| ); |
Why not delete js-yaml from tools/doc/package.json, then delete tools/doc/node_modules/js-yaml and then require js-yaml straight from the ESLint dependency? It is only required here:
Line 3 in 20509eb
| const yaml = require('js-yaml'); |
Metadata
Metadata
Assignees
Labels
docIssues and PRs related to the documentations.Issues and PRs related to the documentations.questionIssues that look for answers.Issues that look for answers.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.