socket close does not follow streams

[ronag]

Not sure if this is a problem or not. But currently net.Socket doesn't quite follow the stream interface.

i.e., https://nodejs.org/api/net.html#net_event_close_1 says 'close' has an argument hadError which stream 'close' is not supposed to have. This can break some code that assumes that streams always emit 'close' without arguments.

[lpinca]

It has been like this for a very long time so I don't think we should change it.

[ronag]

@lpinca true, but it is a bit hacky/difficult to properly implement socket and close while still inheriting from Stream. We would need some kind of special option for destroyImpl so that it does not emit close or override Stream.destroy with a custom implementation.