-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Closed
Labels
assertIssues and PRs related to the assert subsystem.Issues and PRs related to the assert subsystem.
Description
- Version: master
- Platform: any
- Subsystem: assert
> assert.deepStrictEqual('a', 'b') // 'b' is expected
AssertionError [ERR_ASSERTION]: Input A expected to strictly deep-equal input B:
+ expected - actual
- 'a'
+ 'b'I don’t know whether this is an issue of personal preference or not, but it seems to be pretty odd to me that we’re using expected as the diff target, rather than actual. It’s throwing me off every time I see an assertion, so I’m wondering if other people feel the same way.
(I am not sure, but I think this is because the diff target usually presents the current state of things, rather than what it originally was, i.e. when the test was originally written. But that’s just guessing.)
/cc @BridgeAR
devsnek, apapirovski, danbev and lundibundi
Metadata
Metadata
Assignees
Labels
assertIssues and PRs related to the assert subsystem.Issues and PRs related to the assert subsystem.