Bad tab completion for object properties with special characters

[jyn514]

• Version: v8.11.0
• Platform: Linux fedora-thinkpad 4.13.9-300.fc27.x86_64 #1 SMP Mon Oct 23 13:41:58 UTC
• Subsystem: n/a

> d = {'hello, world!': 'some string'}
{ 'hello, world!': 'some string' }
> d.hello<tab>
> d.hello, world!<enter>
... 
... 
> <keyboard interrupt> 

When an object has special characters as one of it's properties, node will autocomplete that property, but continue waiting for input (as the completed property is invalid syntax). This is not desired behaviour.

This issue is also present in Firefox, but not in Chrome.

[addaleax]

@nodejs/repl

[devsnek]

what i did in my repl prototype to fix this was amend our autocomplete regex to allow [ additionally to . and then filter properties based on whether they were doing computed access or dot access and then format the output accordingly:

https://github.com/devsnek/node-repl-prototype/blob/feae58a2de7b91b6e33f4c33194a69678f0bcc20/src/repl.js#L103-L109

i don't know how well this will mesh into our current repl code.

[ryzokuken]

@devsnek did you look into it? Was there any progress?