-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Closed
Labels
cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.workerIssues and PRs related to Worker support.Issues and PRs related to Worker support.
Description
Lines 2157 to 2160 in a40e062
| // XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe | |
| // in the presence of invalid error codes. Probably academical but something | |
| // to keep in mind if/when node ever grows multi-isolate capabilities. | |
| const char* reason = X509_verify_cert_error_string(x509_verify_error); |
Now that we have workers, the scenario described in the comment is here. Do we need to do anything about it? Or can we just change the comment to a simple note rather a XXX?
/cc @addaleax @bnoordhuis
Metadata
Metadata
Assignees
Labels
cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.workerIssues and PRs related to Worker support.Issues and PRs related to Worker support.