-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Closed
Description
-
errorcan be emitted afterclose-
write after end -
invalid argument
-
-
opencan be emitted aftererror - does not use
errorOrDestroyonclose() - should not emit
error, useerrorOrDestroyor callback. -
_writedoes an unnecessary check forinstanceof Buffer(fs: unecessary argument validation #29043). - calling write before fd and closing, will cause write to happen on destroyed stream (i.e. flush after destroy)
- don't use
end()instead ofdestroy(). Keep track of pendingcb instead. (related issue stream: Writable should not invoke _destroy while pending ops #29044) - emit 'close' on destroy
- emit 'close' close error
Metadata
Metadata
Assignees
Labels
No labels