-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Description
We are currently using Github CI for test-asan.yml, test-linux.yml, text-macos.yml which uses the latest version on all of the workflows. Linux CI machines have 2 cores and macOS machines has 3 cores by default. Latest PR by @Trott shows that using -j3 instead of -j2 on macOS builds reduces the build time by 34 minutes (Referencing: #45340).
There was a pull request open by @targos to use large runner (#44908) but later closed due to the unavailability due to Github internals (Referencing @bnb's comment: #44908 (comment)). @richardlau opened a different pull request for using large runners for test-asan (Referencing #45097), but closed it due to Github's billing system (Referencing: #45097 (comment))
Due to the latest issues with macOS machines (referencing: nodejs/build#2917), I'd like to open an issue to keep track of the process of requesting and getting access to large runners on Github. Even though the issue with the macOS builds is not related to the GitHub machines, it might be good to rely more on Github hosts and less on the Jenkins hosts for macOS, maybe with the possibility of removing them entirely.
Even though I don't know what is the correct spec for the node.js builds, afaik the larger the core size, the faster the builds are done. Therefore I believe that getting access to 64 cores of large runners is appropriate for us. (For the full list: https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners)
cc @nodejs/tsc