incoinsistent CJS module loading leads to endless loop

[loynoir]

Version

v18.15.0

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

https://github.com/loynoir/reproduce-node-47971

Load SAME CJS module using

• CJS require

• ESM import

• ESM createRequire

OK when using CJS require

Endless loop when ESM import or ESM createRequire.

How often does it reproduce? Is there a required condition?

See above.

What is the expected behavior? Why is that the expected behavior?

OK when using CJS require.

$ node ./test/test-require.cjs
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
{ plugin: [Module: null prototype] { foo: [Function: foo] } }

What do you see instead?

Endless loop when ESM import or ESM createRequire.

$ node ./test/test-import.mjs
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
...
# endless loop
...

$ node ./test/test-createRequire.mjs
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
waiting import('./plugin.mjs')
...
# endless loop
...

Additional information

https://github.com/abbr/deasync/blob/master/src/deasync.cc#L7C1-L12

[aduh95]

Trying to import a module synchronously is not a supported use case AFAIK. You can try to report the issue to deasync instead.

/cc @nodejs/modules

[loynoir]

@aduh95

deasync core logic seems ~5 lines, so I report issue at here.

Is it possible to make that line work?

https://github.com/abbr/deasync/blob/master/index.js#L68-L73

module.exports.loopWhile = function (pred) {
	while (pred()) {
		process._tickCallback()
		if (pred()) binding.run()
	}
}

https://github.com/abbr/deasync/blob/master/src/deasync.cc#L7-L12

Napi::Value Run(const Napi::CallbackInfo& info) {
  Napi::Env env = info.Env();
  Napi::HandleScope scope(env);
  uv_run(node::GetCurrentEventLoop(v8::Isolate::GetCurrent()), UV_RUN_ONCE);
  return env.Undefined();
}

[bnoordhuis]

I'm going to close this as "not our bug" because what deasync does is what I would diplomatically describe as "unwise". Take it up with its maintainer(s).