-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Closed as not planned
Labels
feature requestIssues that request new features to be added to Node.js.Issues that request new features to be added to Node.js.replIssues and PRs related to the REPL subsystem.Issues and PRs related to the REPL subsystem.
Description
What is the problem this feature will solve?
It might be worth considering upgrading the REPL, given the stability of the work happening at https://github.com/nodejs/repl. However, we would need to (probably) reduce its dependencies before proceeding.
Currently, it relies on the following packages:
"acorn": "^8.7.1",
"acorn-loose": "^8.3.0",
"chalk": "^4.1.2",
"emphasize": "^4.2.0",
"strip-ansi": "^6.0.1",
"ws": "^7.3.0"
Replacing chalk with util.inspect.colors seems feasible (I already have a completed local copy for this). We could substitute ws with WebSocket (native implementation) and strip-ansi with native or built-in methods.
acorn and acorn-loose are already in the /deps folder, leaving only emphasize.
emphasize has ten dependencies, so I'm unsure what we would do to reduce its size.
In summary, I think it's time to revisit the discussion around upgrading the REPL.
Metadata
Metadata
Assignees
Labels
feature requestIssues that request new features to be added to Node.js.Issues that request new features to be added to Node.js.replIssues and PRs related to the REPL subsystem.Issues and PRs related to the REPL subsystem.